Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added main and PR build workflows along with test report generation/uploading, Updated java version #161

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added main and PR build workflows along with test report generation/uploading, Updated java version #161

wants to merge 2 commits into from

Conversation

jaydee029
Copy link

Re raised the old, unmerged PR #160
closed it by mistake while re forking the repository.

For issues

@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

jadecarino
jadecarino requested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks - same as the other PRs please can we change the upload artefacts to only happen on failure, and add the same into the PR builds, both with a retention period of 7 days

@jaydee029
Copy link
Author

Looks good thanks - same as the other PRs please can we change the upload artefacts to only happen on failure, and add the same into the PR builds, both with a retention period of 7 days

done

@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

jadecarino
jadecarino approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for building

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-simplatform-pr-161-7p6bb for details. If you are unable to do so, please contact a member of the Galasa team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadecarino jadecarino jadecarino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaydee029 @galasa-team @jadecarino